Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Music, Movies and TvShows namespaces #1480

Merged
merged 9 commits into from
Nov 19, 2018
Merged

Add Music, Movies and TvShows namespaces #1480

merged 9 commits into from
Nov 19, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Nov 18, 2018

Checklist

Movies

  • Faker::Hobbit => Faker::Movies::Hobbit
  • Faker::HitchhikersGuideToTheGalaxy => Faker::Movies::HitchhikersGuideToTheGalaxy
  • Faker::HarryPotter => Faker::Movies::HarryPotter

Music

  • Faker::RockBand => Faker::Music::RockBand

TvShows

  • Faker::MichaelScott => Faker::TvShows::MichaelScott
  • Faker::RuPaul => Faker::TvShows::RuPaul

This PR is related to #1318

@vbrazo vbrazo self-assigned this Nov 18, 2018
@vbrazo vbrazo changed the title Add TvShows and Movies namespaces Add Music, Movies and TvShows namespaces Nov 18, 2018
@vbrazo vbrazo merged commit 7bd5b72 into faker-ruby:master Nov 19, 2018
@vbrazo vbrazo deleted the deprecate/add-tvshow-movies-namespaces branch November 19, 2018 12:05
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Deprecate ::HarryPotter

* Deprecate ::HitchhikersGuideToTheGalaxy

* Deprecate ::MichaelScott

* Deprecate ::RockBand

* Deprecate ::RuPaul

* Update unreleased_REAMDE.md

* Minor changes

* Minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant