Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dog breed for Japanese #1464

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Add dog breed for Japanese #1464

merged 1 commit into from
Nov 8, 2018

Conversation

yizknn
Copy link
Contributor

@yizknn yizknn commented Nov 8, 2018

Add japanese word to ja.yml and test 🐕

vbrazo
vbrazo approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit 9e20fb7 into faker-ruby:master Nov 8, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@yizknn @vbrazo
Add dog breed for Japanese (faker-ruby#1464)
707e367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@yizknn yizknn

Labels
🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yizknn @vbrazo