Faker::Internet.user_name can't handle UTF-8 arguments

[ivanoblomov]

Because the \w character class is exactly equivalent to [A-Za-z0-9_], we need [[:word:]] to support UTF-8.

Fixes #168.

[ivanoblomov]

@vbrazo, would you know why CI is failing for ruby 2.4.4 and 2.5.1? The patch seems to work correctly locally for both versions.

[vbrazo]

Your solution looks good. What's killing you is the .downcase at the end of the shuffle method: return shuffle(specifier.scan(/[[:word:]]+/)).join(sample(separators)).downcase if specifier.respond_to?(:scan)

From: /faker-ruby/faker/test/test_faker_internet.rb @ line 53 TestFakerInternet#test_username_with_utf_8_arg:

    51: def test_username_with_utf_8_arg
    52:   require 'pry'
 => 53:   binding.pry
    54:   assert @tester.username('Łucja').match('Łucja')
    55: end

[1] pry(#<TestFakerInternet>)> @tester.username('Łucja')
=> "łucja"

[vbrazo]

Now ruby 2.4.4 and 2.5.1 are working and ruby 2.3.7 stopped working 😆

Let me investigate a bit more.

[vbrazo]

@ivanoblomov I know what it is. Ruby 2.3.7 isn't able to convert Łucja/non-ascii strings to downcase. If you try to use .downcase, it'll return the string that you passed without changing it. That's why the test fails - Reference.

Let me know what you think.

[ivanoblomov]

Nice catch @vbrazo, thanks!