Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heroes_of_the_storm.yml #1402

Merged

Conversation

eddorre
Copy link
Contributor

@eddorre eddorre commented Oct 12, 2018

Renames Hanamura to Hanamura Temple as it is now renamed in the latest release. Removes duplicate hero names and entires in hero names array that aren't heroes.

@vbrazo vbrazo changed the title Fix heroes of the storm translation file Update heroes_of_the_storm.yml Oct 12, 2018
@vbrazo vbrazo merged commit 2d593f4 into faker-ruby:master Oct 12, 2018
@eddorre eddorre deleted the fix-heroes-of-the-storm-translation-file branch October 12, 2018 04:12
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Hanamura has been renamed to Hanamura Temple.

* Whitespace changes.

* Removed duplicate hero names.

* Remove non-hero names.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants