Add Faker::Creature::Animal #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A set of animal names, sourced from: https://en.wikipedia.org/wiki/List_of_English_animal_nouns Opportunity to add more Animal options (male/female animal names, young, group names, species names...) Tests and Rubocop passing.
vbrazo
reviewed
Oct 11, 2018
There was a problem hiding this comment.
We have a similar method in the Faker::Team.creature object, but your description makes sense. I think an exclusive module for Animal would be sense.
The question is: should we remove the Faker::Team.creature locale and just call
def self.creature
Faker::Animal.name
end
instead?
|
We're introducing namespaces to keep the gem more organized. Could you wrap this new module in |
|
|
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add Faker::Animal A set of animal names, sourced from: https://en.wikipedia.org/wiki/List_of_English_animal_nouns Opportunity to add more Animal options (male/female animal names, young, group names, species names...) Tests and Rubocop passing. * adds Creature namespace over Animal * updated creature in faker.rb to follow existing pattern * Rubocop fixes * Update animal.md * Update faker.rb * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of animal names, sourced from: https://en.wikipedia.org/wiki/List_of_English_animal_nouns
Opportunity to add more Animal options (male/female animal names, young,
group names, species names...)
Tests and Rubocop passing.