Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Beer.brand #1374

Merged
merged 5 commits into from
Sep 25, 2018
Merged

Add Faker::Beer.brand #1374

merged 5 commits into from
Sep 25, 2018

Conversation

thalesap
Copy link
Contributor

Added some beer brands for using when the application requests a brand name

@thalesap thalesap changed the title PR - Adding beer brands at the context of beer.yml PR - Adding beer brands at beer.yml Sep 25, 2018
vbrazo
vbrazo approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good.

Could you also write a test for this new method and update the doc/beer.md?

@vbrazo vbrazo changed the title PR - Adding beer brands at beer.yml Add Faker::Beer.brand Sep 25, 2018
@vbrazo
Copy link
Member

vbrazo commented Sep 25, 2018

Awesome. I love beer ❤️

Thanks for contributing 🥇

@vbrazo vbrazo merged commit 6c2298e into faker-ruby:master Sep 25, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@thalesap @vbrazo
Add Faker::Beer.brand (faker-ruby#1374)
c52a736 
* CM - Adding beer brands at the context of beer.yml

* CM - More brand names

* CM - lowebrau to lowenbrau

* CM - Adding beer brand at beer.md

* CM - Test beer brand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@thalesap thalesap

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thalesap @vbrazo