Fix flexible keys crash #1292
Merged
Fix flexible keys crash #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you split the test_helper changes into a separate PR? |
deivid-rodriguez
force-pushed
the
fix/flexible_keys_crash
branch
from
dad8fdf
to
a96b718
Compare
|
@stympy Done! |
To make it consistent with the other tests.
deivid-rodriguez
force-pushed
the
fix/flexible_keys_crash
branch
from
a96b718
to
41c058d
Compare
|
Rebased to fix change log conflicts! |
|
This PR also fixes #828 and coincidentally uses the same approach suggested there. |
|
Also fixes #822. |
This was referenced Jun 25, 2018
|
Thanks @stympy! |
Closed
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like with regular keys, flexible keys should default to English when they are not present. Fixes #1286.
There's an unrelated change that simplifies how
test_helperis required. Without this,ruby test/test_flexible.rbwas failing on my environment. Let me know if you want that as a separate PR.