Add Faker::SwordArtOnline #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
May 20, 2018
|
We have conflicts with |
|
I updated the README.md, I'll rebase and push again |
vbrazo
reviewed
May 20, 2018
| en: | ||
| faker: | ||
| sword_art_online: | ||
| real_name: [ |
|
|
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Create docs for Sword Art Online * Create methods for Sword Art Online * Build out arrays for Sword Art Online * Create tests for Sword Art Online * Finish sword_art_online.yml * Finish tests for Sword Art Online * Fix rubocop violations and update changelog.md * Update CHANGELOG.md * Create docs for Sword Art Online * Create methods for Sword Art Online * Build out arrays for Sword Art Online * Create tests for Sword Art Online * Finish sword_art_online.yml * Finish tests for Sword Art Online * Update CHANGELOG.md * Update CHANGELOG.md * Create docs for Sword Art Online * Create methods for Sword Art Online * Build out arrays for Sword Art Online * Create tests for Sword Art Online * Finish sword_art_online.yml * Finish tests for Sword Art Online * Update CHANGELOG.md * Build out arrays for Sword Art Online * Finish sword_art_online.yml * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Sword Art Online real names, game names, locations, and items with appropriate tests and docs. I rebased and ran
bundle && bundle exec rake, all previous and new tests are passing. Rubocop is happy and healthy. Updated CHANGELOG.md.