adds bands, albums, and genres to music #1211
Merged
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
May 16, 2018
There was a problem hiding this comment.
Looks good 💯
Could you please update the CHANGELOG.md and add the title of this PR + your GitHub ID?
|
@vbrazo updated Changelog and rebased. |
Pull Request Test Coverage Report for Build 2138
💛 - Coveralls |
|
Hey Jennifer. What do you think about adding a method to return songs? @jmkoni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was building out a project and realized that there was no faker data for albums/artists/genres. They seemed to fit nicely in music.