Add Faker::Markdown.sandwich #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
requested changes
May 19, 2018
vbrazo
force-pushed
the
master
branch
4 times, most recently
from
a359def
to
a5d7731
Compare
vbrazo
approved these changes
May 28, 2018
|
When will it be released? I'd love to use this! |
|
You could point to our master branch and use it until we release a new version. Only the owner could release the 1.8.8, so I'm sure when it'll happen. |
|
@krsnachandra we released a new version this month. |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* corrected typo on dune.md * get rid of ahead of myself dune.md changes * add documentation and extended sandwich artistry * tests pass ready to party * remove dune.md changes on my machine * Update changelog * Add missing sandwich tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take on issue 1052... this creates a fake markdown text block starting with a header and then a variable number of sentences in a lorem ipsum paragraph and then a random markdown element. Users can repeat that duo of lorem paragraph and random markdown element if they want longer text blocks.
Since I am recycling other methods, I wasn't totally sure what to test for here other than the iteration on a default case had the right number of pieces.