Markdown exclude method #1062
Merged
Markdown exclude method #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
May 19, 2018
vbrazo
force-pushed
the
master
branch
4 times, most recently
from
a359def
to
a5d7731
Compare
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* corrected typo on dune.md * lib/faker/markdown.rb * accept multiple arguments & change to documentation * fix array length in markdown#random send line * tests pass * remove change to dune.md that crept in & is on sep PR 1057 * Minor fix * Fix merge issues * Update CHANGELOG.md * Omit failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted solution for Issue 1052... I am having a harder time with the test than the changes to
random. The modifiedrandommethod takes a comma-separated list of strings and if they match to aMarkdownmethod, they won't be in the source array that a method is randomly pulled from.I am no expert yet so what is the best way to test for this? Basically we are trying to prove a negative. The test I threw out there is that we test for a false positive (refute_equal) 20 times. Since there are 10 methods, (1/10)^20 should be pretty hard to achieve if the 'random' method is in fact still calling the excluded method. I am trying to balance the need to get close to zero probability and not be too much of a CPU-hog when running tests. Very open to learning a better way to do this!