-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terratest: Basic usage test #23
Conversation
fcf83a9
to
c6f85ea
Compare
c6f85ea
to
c114b66
Compare
c114b66
to
bb7c03a
Compare
- ALB cannot be attached to one AZ/Subnet more than once
As expected, adding this basic test, some bugs were found 😄 but now they are fixed and included in this PR 1 - Internal Module AWS region: The AWS region is used in some policies/interpolation files and by default it was 2 - ALB's public subnets: All the Public Subnets generated by the VPC module were attached to the Internet-facing Load Balancer but if there is at least more than one subnet repeating AZs, the ALB couldn't be created. This is the case for some regions like São Paulo 🇧🇷that (in this moment) only has 2 AZs. So now, the number of subnets attached to the ALB is less or equal to the number of AZs in the current region 👍 |
This is the beginning of tests use cases using Terratest 👍
So far, the only test ensures that the module is deployable using basic settings (described in the basic example).
I've faced many issues learning Golang (and its module's resolution) and I'm not happy how thego test
command looks like inside the TravisCI config, so probably some help would be great 🙏EDIT: Thanks @honzahovorka @varholak-peter for the help with the go modules 🍻
Closes: #11