Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad warning when retrieving plan for connected account #393

Closed
deatheragetr opened this issue Oct 3, 2017 · 4 comments
Closed

Bad warning when retrieving plan for connected account #393

deatheragetr opened this issue Oct 3, 2017 · 4 comments
Assignees

Comments

@deatheragetr
Copy link

Stripe-node version: 5.1.0;
Node version: 8.6.0 (Oddly, I only discovered this on upgrading from node 6.x.x to 8.x.x)

Behavior works as expected for retrieving a subscription plan on a connected account; however, a warning is logged. I believe this warning is wrong.

stripe
.plans
.retrieve('foo-sub-plan', { stripe_account: 'foo-stripe-account' })
.then(plan => console.log(plan))

logs the following:

Stripe: Options found in arguments (stripe_account). Did you mean to pass an options object? See https://github.com/stripe/stripe-node/wiki/Passing-Options.

{
  id: 'foo-sub-plan'
  ....plan-details
}

Since, I'm calling plans.retrieve the way the documentation suggests, and since it's behaving as I would expect, I assume that's a bad warning.

Anyway, confused me a bit as I was debugging a separate, but subscription-plans related issue.

Best,

@jlomas-stripe
Copy link
Contributor

That ... is interesting. :) We recently added that warning, but it definitely shouldn't be appearing there. I'll have a look at this shortly - thanks for bringing it up!

@deatheragetr
Copy link
Author

Of course, thanks for the quick response!

@brandur-stripe
Copy link
Contributor

Thanks for reporting this! We've released a fix in 5.1.1.

@deatheragetr
Copy link
Author

Great thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants