Send object=bank_account when using AccountExternalAccountParams
#486
Conversation
When using `AccountExternalAccountParams` for creating a bank account from an account, sending an `object` field is required. Here we give the params struct a custom `AppendTo` so that we can comply with this logic. Partial fix for #485.
|
lgtm in the specific context of #485, but ideally we should also be able to handle the following cases:
At the moment I think the library is not capable of either of these. This can be handled in a future PR though. |
We explicitly refuse to support this one since it's not PCI compliant and would be blocked for almost all users by default. |
|
Worked with @brandur-stripe on this and pushed a fix for the token part so that you can send it as needed. |
|
Nice! Mind adding a test for the token case? |
|
I looked unfortunately I don't understand the mock logic for this test case. I get a |
|
Good call on the additional functionality @ob-stripe, and thanks for the patch @remi-stripe! Added an additional test in f7de6b1 and am bringing this one in. |
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) from 0.5.10073 to 0.5.10090. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
When using
AccountExternalAccountParamsfor creating a bank accountfrom an account, sending an
objectfield is required. Here we give theparams struct a custom
AppendToso that we can comply with this logic.Partial fix for #485.
r? @ob-stripe