-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 3.13 to non dev #3665
Bump 3.13 to non dev #3665
Conversation
Reviewer's Guide by SourceryThis pull request updates the Python version from 3.13-dev to 3.13 in the GitHub Actions workflow and adjusts the Django tests to run on Python 3.12 and 3.13 instead of 3.11 and 3.12. These changes likely aim to use the latest stable version of Python 3.13 and update the testing matrix accordingly. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patrick91 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
+ Coverage 96.67% 96.93% +0.26%
==========================================
Files 504 504
Lines 33448 33448
Branches 5600 5600
==========================================
+ Hits 32335 32423 +88
+ Misses 880 793 -87
+ Partials 233 232 -1 |
CodSpeed Performance ReportMerging #3665 will not alter performanceComparing Summary
|
I think we can't run Django 4.0 and 3.2 tests with 3.13 as they use the |
Doing this PR to also check why tests in #3639 are broken
Summary by Sourcery
Update the testing configuration to use Python 3.13 instead of the development version 3.13-dev in both the GitHub Actions workflow and Nox test sessions.
CI:
Tests: