Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 3.13 to non dev #3665

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Bump 3.13 to non dev #3665

merged 2 commits into from
Oct 9, 2024

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Oct 8, 2024

Doing this PR to also check why tests in #3639 are broken

Summary by Sourcery

Update the testing configuration to use Python 3.13 instead of the development version 3.13-dev in both the GitHub Actions workflow and Nox test sessions.

CI:

  • Update the GitHub Actions workflow to use Python 3.13 instead of 3.13-dev for testing.

Tests:

  • Modify the Nox configuration to include Python 3.13 in the Django test sessions, replacing Python 3.11.

Copy link
Contributor

sourcery-ai bot commented Oct 8, 2024

Reviewer's Guide by Sourcery

This pull request updates the Python version from 3.13-dev to 3.13 in the GitHub Actions workflow and adjusts the Django tests to run on Python 3.12 and 3.13 instead of 3.11 and 3.12. These changes likely aim to use the latest stable version of Python 3.13 and update the testing matrix accordingly.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update Python version from 3.13-dev to 3.13 in GitHub Actions workflow
  • Replace '3.13-dev' with '3.13' in the Python versions list
.github/workflows/test.yml
Modify Django tests to run on Python 3.12 and 3.13
  • Change Python versions for Django tests from '["3.11", "3.12"]' to '["3.12", "3.13"]'
noxfile.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patrick91 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (0bc9773) to head (0aa763d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
+ Coverage   96.67%   96.93%   +0.26%     
==========================================
  Files         504      504              
  Lines       33448    33448              
  Branches     5600     5600              
==========================================
+ Hits        32335    32423      +88     
+ Misses        880      793      -87     
+ Partials      233      232       -1     

Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #3665 will not alter performance

Comparing py313 (0aa763d) with main (0bc9773)

Summary

✅ 15 untouched benchmarks

@bellini666
Copy link
Member

I think we can't run Django 4.0 and 3.2 tests with 3.13 as they use the cgi module, which was deprecated and got removed.

@patrick91 patrick91 merged commit 596461b into main Oct 9, 2024
99 of 100 checks passed
@patrick91 patrick91 deleted the py313 branch October 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants