Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some lint fixes #3578

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Some lint fixes #3578

merged 3 commits into from
Jul 23, 2024

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Jul 23, 2024

Now we can use the stable mypy release 😊

Copy link
Contributor

sourcery-ai bot commented Jul 23, 2024

Reviewer's Guide by Sourcery

This pull request refactors the CLI command registration by replacing individual command imports with typer.Typer instances and registering these instances in the main CLI app. Additionally, it removes unnecessary # type: ignore comments from method definitions in base_extension.py and updates the return type of the __or__ method in lazy_type.py.

File-Level Changes

Files Changes
strawberry/cli/__init__.py
strawberry/cli/commands/codegen.py
strawberry/cli/commands/export_schema.py
strawberry/cli/commands/schema_codegen.py
strawberry/cli/commands/server.py
strawberry/cli/commands/upgrade/__init__.py
Refactored CLI command registration to use individual typer.Typer instances for each command module.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@botberry
Copy link
Member

botberry commented Jul 23, 2024

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #3578 will not alter performance

Comparing fix/nox-lint (fa9067a) with main (3389c66)

Summary

✅ 13 untouched benchmarks

@botberry
Copy link
Member

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@patrick91 patrick91 enabled auto-merge (squash) July 23, 2024 21:23
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (3389c66) to head (fa9067a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3578      +/-   ##
==========================================
- Coverage   96.58%   94.39%   -2.19%     
==========================================
  Files         526      522       -4     
  Lines       33914    32755    -1159     
  Branches     5594     3736    -1858     
==========================================
- Hits        32755    30920    -1835     
- Misses        922     1550     +628     
- Partials      237      285      +48     

@patrick91 patrick91 disabled auto-merge July 23, 2024 21:28
@patrick91 patrick91 merged commit 494d540 into main Jul 23, 2024
63 of 65 checks passed
@patrick91 patrick91 deleted the fix/nox-lint branch July 23, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants