-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen generic types #3077
Codegen generic types #3077
Conversation
5ac49eb
to
52f2661
Compare
Thanks for adding the Here's a preview of the changelog: This fixes a bug where codegen would choke trying to find a field in the schema for a generic type. Here's the preview release card for twitter: Here's the tweet text:
|
Thanks for adding the Here's a preview of the changelog: This fixes a bug where codegen would choke trying to find a field in the schema for a generic type. Here's the preview release card for twitter: Here's the tweet text:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
==========================================
- Coverage 96.49% 96.48% -0.01%
==========================================
Files 467 467
Lines 29149 29163 +14
Branches 3585 3588 +3
==========================================
+ Hits 28126 28137 +11
- Misses 842 845 +3
Partials 181 181 |
CodSpeed Performance ReportMerging #3077 will not alter performanceComparing Summary
|
1a7b5a7
to
1f4afd8
Compare
1f4afd8
to
1f18a4f
Compare
Co-authored-by: Matt Gilson <mgilson@lat.ai>
Codegen currently chokes on generic types. Let's make that not happen. (My team ran in this with Pagination APIs where a Page was generic on the type of items that it contains).
Description
Simply update the name of the field that we are searching for in the schema for generic types.
Types of Changes
Issues Fixed or Closed by This PR
Checklist