Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2.0.0 file #3051

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Remove 2.0.0 file #3051

merged 5 commits into from
Aug 23, 2023

Conversation

patrick91
Copy link
Member

I noticed we added this file by mistake 😊

(I'm also using this PR to check that the release comment still works)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #3051 (05c1f63) into main (4eb629e) will decrease coverage by 0.01%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

❗ Current head 05c1f63 differs from pull request most recent head 7d96379. Consider uploading reports for the commit 7d96379 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3051      +/-   ##
==========================================
- Coverage   96.53%   96.53%   -0.01%     
==========================================
  Files         468      468              
  Lines       29116    29195      +79     
  Branches     3582     3587       +5     
==========================================
+ Hits        28108    28183      +75     
- Misses        827      828       +1     
- Partials      181      184       +3     

@botberry
Copy link
Member

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

This reverts commit 05c1f63.
@patrick91 patrick91 merged commit 8877b21 into main Aug 23, 2023
2 checks passed
@patrick91 patrick91 deleted the remove-file branch August 23, 2023 23:06
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 23, 2023

CodSpeed Performance Report

Merging #3051 will not alter performance

Comparing remove-file (05c1f63) with main (579a1d0)

Summary

✅ 12 untouched benchmarks

etripier pushed a commit to Greenbax/strawberry that referenced this pull request Oct 25, 2023
* Remove 2.0.0 file

* Test: ignore this commit

* Revert "Test: ignore this commit"

This reverts commit f1b1c69.

* Ignore

* Revert "Ignore"

This reverts commit 05c1f63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants