Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on 3.12 #2958

Merged
merged 6 commits into from
Jul 30, 2023
Merged

Test on 3.12 #2958

merged 6 commits into from
Jul 30, 2023

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Jul 16, 2023

For real this time :D

This also removes tests on 3.7, so we should merge this after #2907 😊

We should also introduce tests for the new features (inline generics)

@botberry
Copy link
Member

botberry commented Jul 16, 2023

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@botberry
Copy link
Member

botberry commented Jul 16, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 16, 2023

CodSpeed Performance Report

Merging #2958 will not alter performance

Comparing feature/test-312-2 (1cced51) with main (4b9e8bb)

Summary

✅ 12 untouched benchmarks

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #2958 (1cced51) into main (4b9e8bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2958   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         467      467           
  Lines       28905    28909    +4     
  Branches     3545     3545           
=======================================
+ Hits        27892    27896    +4     
  Misses        827      827           
  Partials      186      186           

@patrick91 patrick91 merged commit c6e6575 into main Jul 30, 2023
40 checks passed
@patrick91 patrick91 deleted the feature/test-312-2 branch July 30, 2023 17:14
etripier pushed a commit to Greenbax/strawberry that referenced this pull request Oct 25, 2023
* Test on 3.12

* Better warnings filters

* update lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants