Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface performance benchmark #2948

Conversation

skilkis
Copy link
Contributor

@skilkis skilkis commented Jul 13, 2023

Description

Test interface performance on a resolver returning 1000 objects. Parametrized test checks that execution time does not grow with increasing number of implementations

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2948 (d7d0928) into main (efcd602) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2948      +/-   ##
==========================================
- Coverage   96.11%   96.08%   -0.03%     
==========================================
  Files         211      211              
  Lines        9232     9232              
  Branches     1489     1489              
==========================================
- Hits         8873     8871       -2     
- Misses        229      230       +1     
- Partials      130      131       +1     

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 13, 2023

CodSpeed Performance Report

Merging #2948 will not alter performance

Comparing skilkis:feature/benchmark_interface_performance (d7d0928) with main (fb7a9c4)

Summary

✅ 1 untouched benchmarks

🆕 4 new benchmarks

Benchmarks breakdown

Benchmark main skilkis:feature/benchmark_interface_performance Change
🆕 test_interface_performance[1] N/A 274.8 ms N/A
🆕 test_interface_performance[16] N/A 363 ms N/A
🆕 test_interface_performance[256] N/A 1.8 s N/A
🆕 test_interface_performance[4096] N/A 6.4 s N/A

@skilkis
Copy link
Contributor Author

skilkis commented Jul 14, 2023

@patrick91 this PR is to add codspeed results on main before we merge #1949 . Is it possible to merge this without making a release?

@patrick91 patrick91 merged commit 1360e30 into strawberry-graphql:main Jul 14, 2023
28 of 29 checks passed
etripier pushed a commit to Greenbax/strawberry that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants