Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on 3.12-dev #2809

Closed
wants to merge 19 commits into from
Closed

Run tests on 3.12-dev #2809

wants to merge 19 commits into from

Conversation

patrick91
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #2809 (eaece6f) into main (efcd602) will decrease coverage by 8.19%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
- Coverage   96.11%   87.92%   -8.19%     
==========================================
  Files         211      211              
  Lines        9232     9232              
  Branches     1489     1489              
==========================================
- Hits         8873     8117     -756     
- Misses        229      918     +689     
- Partials      130      197      +67     

@botberry
Copy link
Member

botberry commented Jun 27, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@DoctorJohn
Copy link
Member

DoctorJohn commented Jun 27, 2023

Did a little investigation. The first error we see is this:

Note: This error originates from the build backend, and is likely not a problem with poetry but with frozenlist (1.3.3) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "frozenlist (==1.3.3)"'.

Which made me think our issue is related to aio-libs/frozenlist#296 which lead me to this fix or workaround: aio-libs/aiohttp#3704

But actually it looks like our build backend might be working just fine, it's just gcc actually failing to compile frozenlist:

error: ‘PyLongObject’ {aka ‘struct _longobject’} has no member named ‘ob_digit’

This error leads to a cython issue cython/cython#5238. I'm now experimenting on the side with pinning newer cython versions. (no solution yet, just wanted to share some thoughts).

EDIT: there is an issue for this in the frozenlist repo aio-libs/frozenlist#433

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 12, 2023

CodSpeed Performance Report

Merging #2809 will not alter performance

Comparing feature/test-312 (eaece6f) with main (efcd602)

Summary

✅ 1 untouched benchmarks

@patrick91 patrick91 closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants