Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce diff of ASIC resources during CI #247

Open
ccascone opened this issue Apr 24, 2021 · 0 comments
Open

Produce diff of ASIC resources during CI #247

ccascone opened this issue Apr 24, 2021 · 0 comments
Labels
QA Quality Assurance

Comments

@ccascone
Copy link
Member

ccascone commented Apr 24, 2021

Wouldn't it be nice if we could get something like a codecov report for each PR, but instead of showing the coverage diff, it would show the diff in terms of utilization of PHV, stages, memory, etc.?

Today, we assume PR authors use p4i to check the impact on ASIC resource utilization when making design decisions. However, it's easy to forget and/or get confused when we have so many different build profiles, and it takes so long to build one.

Posting such ASIC resource diff would reduce the burden on PR authors to manually build and compare profiles, and would provide reviewers with more data to perform more informed reviews in less time. This issue was motivated by this comment on PR #246.

If there's a legal problem publishing the output of p4i as a PR comment, we could upload it as a Jenkins artifact, accessible only to ONF community members who have an agreement with Intel (like we do for the PR verification job).

@ccascone ccascone added the QA Quality Assurance label Apr 24, 2021
@ccascone ccascone changed the title Provide diff of ASIC resources as part of CI Produce diff of ASIC resources during CI Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Quality Assurance
Projects
None yet
Development

No branches or pull requests

1 participant