Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure this works with our getfile script and "lock down files" methods #39

Open
ideadude opened this issue Apr 5, 2018 · 1 comment
Milestone

Comments

@ideadude
Copy link
Member

ideadude commented Apr 5, 2018

Someone on the forums mentioned that users who weren't approved could gain access to files anyway.

Since we call pmpro_has_membership_access() here https://github.com/strangerstudios/paid-memberships-pro/blob/dev/services/getfile.php#L74 that should be filtered by PMPro Approvals, but maybe the plugin hasn't loaded yet or something else is going on.

This custom gist (for locking down files outside of WP) uses the pmpro_hasMembershipLevel function and should also be filtered. https://gist.github.com/strangerstudios/6599510#file-my_pmpro_getfile-php-L64

If the user is using a custom getfile script anyway, it could be updated to check the status of the user's membership.

@andrewlimaza andrewlimaza added this to the 1.4 milestone Jan 23, 2020
@gausam
Copy link
Contributor

gausam commented Sep 17, 2020

@andrewlimaza The Approvals Add On filters the membership level correctly in all the scenarios I tested with. Something else was probably off in the user's installation or the Add On hadn't loaded yet for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants