Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Jest and related packages in the dependencies be upgrades to vesion 29.x.x? #298

Closed
rpellerin opened this issue Apr 26, 2023 · 8 comments

Comments

@rpellerin
Copy link

Currently, these are outdated and prevent upgrades on the projects that use @storybook/test-runner because of incompatible Jest typescript types.

        "jest": "^28.0.0",
        "jest-circus": "^28.0.0",
        "jest-environment-node": "^28.0.0",
        "jest-junit": "^14.0.0",
        "jest-playwright-preset": "^2.0.0",
        "jest-runner": "^28.0.0",
        "jest-serializer-html": "^7.1.0",
        "jest-watch-typeahead": "^2.0.0",
@MashaSinkevich
Copy link

Is there any chance that this can be prioritized please as now update to Jest 29+ is important due to an important fix for NodeJS memory leek (see https://jestjs.io/docs/29.0/configuration/#workeridlememorylimit-numberstring)?

@yannbf
Copy link
Member

yannbf commented Jun 20, 2023

Hey everyone! Could you please try this version out and provide feedback? It upgrades all dependencies to Jest 29:

yarn add -D @storybook/test-runner@0.12.0--canary.319.1d0defe.0

@bryanjtc
Copy link
Member

bryanjtc commented Jun 21, 2023

Testing my project with 60 component tests, everything is good. No errors.

@MashaSinkevich
Copy link

MashaSinkevich commented Jun 21, 2023

Works great for my project (1000+ tests), with no errors.

@legobeat
Copy link
Contributor

legobeat commented Sep 3, 2023

@yannbf #345 or #348 ? :)

@piratetaco
Copy link

can these dependencies just be set as peerDependencies? Most of the time users will already be using jest for other purposes and as long as we're compatible we don't have to gum up yarn locks or cause potential conflicts.

@yannbf
Copy link
Member

yannbf commented Oct 30, 2023

@piratetaco that's a great question, and sorry to hear you're having troubles because of this!

We chose to set Jest as a direct dependency for a few reasons:

  1. The test-runner uses jest-playwright-preset, jest-circus and other packages which correlate to a certain version of jest, they should be coordinated.
  2. The test-runner is supposed to work out of the box for projects even if they do not use Jest. Jest is supposed to be an implementation detail.

@yannbf
Copy link
Member

yannbf commented Oct 30, 2023

Hey everyone! I'm happy to say that the test-runner now uses Jest 29, please try its beta version here:
v0.14.0-next.2

It will be promoted to latest once it has enough feedback regarding its stability. Thank you! <3

@yannbf yannbf closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants