Addons: Scaffold Addon Vitest #28810
Conversation
![greptile-apps[bot]](https://github.com/avatars/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
29 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings
| ) => { | ||
| return async ({ task, skip }: TaskContext) => { | ||
| const Story = (await getStories(modulePath, composeStoriesFn))[exportName]; | ||
| if (Story === undefined || shouldSkip(Story.tags, tagsFilter)) { |
There was a problem hiding this comment.
logic: Potential issue if Story.tags is undefined. Consider adding a check.
| }; | ||
| _task.meta.storyId = Story.id; | ||
| _task.meta.hasPlayFunction = !!Story.play; | ||
| await setViewport(Story.parameters.viewport); |
There was a problem hiding this comment.
logic: Potential issue if Story.parameters.viewport is undefined. Consider adding a check.
|
|
||
| let page: BrowserPage; | ||
| try { | ||
| const importPath = '/@id/__x00__@vitest/browser/context'; |
There was a problem hiding this comment.
style: Consider handling the case where importPath fails more gracefully.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 12e0350. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
force-pushed
the
yann/addon-vitest-barebones-with-plugin
branch
from
ee720ec
to
52aa6fd
Compare
code/addons/vitest/package.json
Outdated
| "exports": { | ||
| ".": { | ||
| "types": "./dist/index.d.ts", | ||
| "node": "./dist/index.cjs", |
There was a problem hiding this comment.
Do we need a cjs bundle?
Closes #
What I did
This PR bases on the work from #28749 and does the following:
The work in #28749 will be revisited later once we introduce UI coming from the addon. Fow now we are focusin on the CLI aspect of it.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Introduced a new Vitest addon for Storybook, integrating Vitest test results with Storybook stories.
code/.storybook/main.tsto include the Vitest addon.code/.storybook/storybook.setup.tsfor Vitest setup.code/addons/vitest/src/plugin/index.tsto configure the Vitest plugin.code/core/src/manager-api/modules/stories.tsto enhanceexperimental_updateStatus.code/package.jsonto include@storybook/experimental-addon-vitestand@vitest/browserdependencies.