Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Add of prop to Title #23728

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Conversation

Sidnioulz
Copy link
Contributor

@Sidnioulz Sidnioulz commented Aug 5, 2023

Partially implements #22490

What I did

How to test

  • Run yarn storybook:ui
  • Open Storybook in your browser
  • Access Title stories

Questions for maintainers

  • Do I need to update MIGRATION.md in this instance?
  • Do I need to preserve the default attached behaviour or deprecate it?

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen changed the title feat: Update title to support 'of' prop Addon-Docs: Title blocks to support 'of' prop Sep 4, 2023
@ndelangen ndelangen changed the title Addon-Docs: Title blocks to support 'of' prop Addon-Docs: Title blocks to support of prop Sep 4, 2023
@ndelangen ndelangen assigned JReinhold and unassigned ndelangen Sep 6, 2023
@yannbf
Copy link
Member

yannbf commented Oct 2, 2023

Hey @JReinhold could you please take a look?

@ndelangen
Copy link
Member

@JReinhold Is this an easy PR to review & merge?

Copy link

nx-cloud bot commented Apr 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 51ede75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and your patience. I modified it slightly, LGTM. ❤️

@JReinhold JReinhold merged commit 37b8aef into storybookjs:next Apr 23, 2024
49 of 51 checks passed
@github-actions github-actions bot mentioned this pull request May 3, 2024
44 tasks
@shilman shilman changed the title Addon-Docs: Title blocks to support of prop Blocks: Add of prop to Title block May 5, 2024
@shilman shilman changed the title Blocks: Add of prop to Title block Blocks: Add of prop to Title May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants