Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react story template violates jsx-a11y/accessible-emoji eslint rule #2736

Closed
shobhitchittora opened this issue Jan 13, 2018 · 3 comments
Closed

Comments

@shobhitchittora
Copy link

Recently I bootstrapped my new project using react-boilerplate and added storybook to it using getstorybook command.
This worked perfectly ( Thanks! ).

React-boilerplate has precommit hooks which disallows to push code with eslint errors. It'd be great if we can play well with eslint rules and fix our boilerplate stories.

Will create a PR if we all concur.

@shobhitchittora
Copy link
Author

Putting the error here for everyone's reference -

 error  Emojis should be wrapped in <span>, have role="img", and have an accessible description with aria-label or aria-labelledby  jsx-a11y/accessible-emoji

@stale
Copy link

stale bot commented Feb 27, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Feb 27, 2018
@stale stale bot removed the inactive label Feb 27, 2018
@Hypnosphi
Copy link
Member

Fixed in v3.4.0-alpha.9 with #3011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants