Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No LiveReload on completely fresh CRNA + storybook. #1838

Closed
deehuey opened this issue Sep 13, 2017 · 2 comments
Closed

No LiveReload on completely fresh CRNA + storybook. #1838

deehuey opened this issue Sep 13, 2017 · 2 comments

Comments

@deehuey
Copy link

deehuey commented Sep 13, 2017

Hey there, I've followed a guide to set up a brand new CRNA and storybook environment.

After running getstorybook in a fresh CRNA, and changing the App.js to

export default from './storybook'

I can see that my app is running, and i can view the emoji / "Hello Button" buttons, and see the actions and all, but if I change the button text to "Hello Buttonnnnnnnn" I'll see the "Hot loading..." notification on my phone, but it won't actually update until I toggle from one story, and then back to the story I'm on. (Meaning it's half working, but I don't see changes until rerendering)

Current package.json

  "devDependencies": {
    "react-native-scripts": "1.3.1",
    "jest-expo": "~20.0.0",
    "react-test-renderer": "16.0.0-alpha.12",
    "@storybook/react-native": "^3.2.8",
    "@storybook/addon-actions": "^3.2.6",
    "@storybook/addon-links": "^3.2.6",
    "react-dom": "16.0.0-alpha.12",
    "prop-types": "^15.5.10"
  },
  "main": "./node_modules/react-native-scripts/build/bin/crna-entry.js",
  "scripts": {
    "start": "react-native-scripts start",
    "eject": "react-native-scripts eject",
    "android": "react-native-scripts android",
    "ios": "react-native-scripts ios",
    "test": "node node_modules/jest/bin/jest.js --watch",
    "storybook": "storybook start -p 7007"
  },
  "jest": {
    "preset": "jest-expo"
  },
  "dependencies": {
    "babel-preset-es2015": "^6.24.1",
    "babel-preset-stage-2": "^6.24.1",
    "expo": "^20.0.0",
    "react": "16.0.0-alpha.12",
    "react-native": "^0.47.0"
  }

The livereloading was working on the CRNA app itself.

@danielduan
Copy link
Member

I think I've came across this at one point as well. Can anyone else reproduce this on the latest or 3.3-alpha?

@danielduan
Copy link
Member

danielduan commented Nov 2, 2017

fixed #2194

for existing projects, you'll need to replace the root storybook app with a react-native class component instead of a functional stateless component
#2081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants