Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract default webpack and publish as package #1098

Closed
ndelangen opened this issue May 22, 2017 · 4 comments
Closed

extract default webpack and publish as package #1098

ndelangen opened this issue May 22, 2017 · 4 comments

Comments

@ndelangen
Copy link
Member

ndelangen commented May 22, 2017

We see people using our webpack config by including it, and we even document it.
@storybook/react/dist/server/config/webpack.config

But reaching deep into a package is a bad practice, because it's fragile, and makes it harder for us to refactor.

We should publish the default webpack config as it's own package.

@heinzmuller
Copy link
Contributor

Just a thought, but what about having it as a named export?

import { webpackConfig } from "@storybook/react"

@ndelangen
Copy link
Member Author

yeah valid point, that's an option too!

@ndelangen
Copy link
Member Author

Care to make this into a PR @heinzmuller ?

@ndelangen
Copy link
Member Author

We found a better solution where the default is passed as a parameter in full control mode.

@issue-sh issue-sh bot removed the todo label May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants