Passing argument to ghdl_sim.sh - bug?

[stnolting]

@umarcor

Currently, the riscv-arch-test worklfow does not work.

I think there might be a problem here:

neorv32/sim/ghdl/ghdl_sim.sh

Lines 19 to 24 in b53feb7

	# Simulation time define by user?
	echo ""
	[ -z ${1} ] && echo "Using default simulation config: $SIM_CONFIG" || (
	SIM_CONFIG=$1;
	echo "Using user simulation config: $SIM_CONFIG";
	)

When passing the max. simulation time from a makefile, SIM_CONFIG does not seem to be updated globally.

neorv32/riscv-arch-test/port-neorv32/framework_v2.0/riscv-target/neorv32/device/rv32i_m/I/Makefile.include

Line 36 in b53feb7

sh $(NEORV32_LOCAL_COPY)/sim/ghdl/ghdl_sim.sh --stop-time=$(SIM_TIME) >> /dev/null; \

Hence the simulation runs for the default time (8ms) - which would take ages for the riscv-arch-test to complete. When I use the code below for ghdl_sim.sh it seems to work.

if [ -z $1 ]
then
  echo "Using default simulation config: $SIM_CONFIG"
else
  echo $1;
  SIM_CONFIG=$1;
  echo "Using user simulation config: $SIM_CONFIG";
fi

I am not a bash expert, though. Where is the difference? Does the updated code do anything that my workaround does not?! 🤔

[umarcor]

@stnolting, my bad. I didn't realise that SIM_CONFIG is kept local. I guess we can either export it in L22, or change it to your style. As you wish.

[stnolting]

No problem!
I will update that. Hopefully nothing else breaks 😅