Feat/Model Systems to Fractal and React Package #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-sand-0da50520f-92.eastus2.azurestaticapps.net |
jamesmadson
approved these changes
Dec 17, 2021
acchiao
pushed a commit
that referenced
this pull request
Apr 7, 2022
* bump @stjudecloud/assets and pin @babel/preset-env * fractal: adds model systems icon and uses it in footer and omnibar * bumps @stjudecloud/assets * react: adds model systems to omnibar and footer Co-authored-by: Andrew Swistak <andrew@andrewswistak.com> 0213526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar but slight restructure from the last PR given the release of the assets package that included the needed Model Systems .png. This PR adds "Model Systems"
Additionally, as mentioned in the other PR, I had problems compiling the scss through parcel bundler for Fractal but pinning @babel/preset-env to 7.13.8 seems to have resolved it (same issue and used fix as described in this issue).
This is ensuring we are ahead and will not be merged in until the Model Systems app ready to go.