-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate 'row.names' are not allowed #123
Comments
This error suggests that you have multiple rows in your input metadata with the same cell ID (ie the |
Sorry I should have tested it before, you were right. If it's not too annoying we could capture this error with a more informative message.
|
Would you rather I test the input data frame for duplicates (big performance implications), or just catch errors resulting from the code where I try to set the row names, and throw a better error message? |
Would
take long for 100M rows? or faster methods here https://stackoverflow.com/questions/37148567/fastest-way-to-remove-all-duplicates-in-r or just to check if duplicates exist -> anyDuplicated ... But maybe catching the error is the actually right thing to do, as it is exactly what we are doing, replacing an error with another. |
Yeah the performance hit probably won't be too bad compared to the time it takes to actually download and process the data. I think the best function to use to detect duplicates would be one that Up to you though. |
the input could easily be a tibble, incase you manipulate first. I think catching the error is the most transparent thing we can do. |
Hi @multimeric ,
I get this error for this query
The text was updated successfully, but these errors were encountered: