Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try hooking up MIRAI #1158

Open
2 tasks
graydon opened this issue Nov 1, 2023 · 1 comment
Open
2 tasks

Try hooking up MIRAI #1158

graydon opened this issue Nov 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@graydon
Copy link
Contributor

graydon commented Nov 1, 2023

We should try hooking up MIRAI to soroban to see if it can find panics we aren't aware of. This might be a bottomless task, so time-box it:

  • see if it can find all (or any) interesting panics
  • see if it can output a call graph (in one of its datalog formats) such that we can find interesting recursion paths
@graydon graydon added the bug Something isn't working label Nov 1, 2023
@sisuresh sisuresh assigned sisuresh and unassigned sisuresh Nov 6, 2023
@graydon
Copy link
Contributor Author

graydon commented Nov 27, 2023

I tried this today and it finds nothing on soroban-env-common and crashes trying to analyze soroban-env-host

I did check that it "basically works" by putting in some egregious out-of-bounds indexes that it catches. It doesn't catch explicit panics, which seems surprising to me, but maybe that's intentional? The docs aren't really clear on what it expects to catch.

I don't think this is going to be especially constructive within the next week. We can keep poking at it but I'm going to bump this down from P0 to P1. It's not mature enough to rely on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@graydon @sisuresh and others