Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Happy Birthday" dataset #191

Closed
wants to merge 1 commit into from
Closed

Add "Happy Birthday" dataset #191

wants to merge 1 commit into from

Conversation

beyza17
Copy link

@beyza17 beyza17 commented Jul 13, 2024

I added new shape as happy birthday.
Fixes #189

-Created happy_birthday.csv
-Added 'happy_birthday': 'happy_birthday.csv' to _DATASETS: dict = {

Checklist

  • [ X] Test cases have been modified/added to cover any code changes.
  • [X ] Docstrings have been modified/created for any code changes.
  • [X ] All linting and formatting checks pass (see the contributing guidelines for more information).

@github-actions github-actions bot added the data Work relating to data module label Jul 13, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.

@stefmolin stefmolin changed the title Added happy_birthday.csv and data loader Add "Happy Birthday" dataset Jul 13, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (2b0666e) to head (7f1f562).
Report is 27 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   98.38%   98.41%   +0.02%     
==========================================
  Files          43       43              
  Lines        1737     1765      +28     
  Branches      345      356      +11     
==========================================
+ Hits         1709     1737      +28     
  Misses         25       25              
  Partials        3        3              
Files Coverage Δ
src/data_morph/data/loader.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@stefmolin stefmolin closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Work relating to data module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add happy_birthday start shape
3 participants