-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add x and y medians to plot #188
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 98.42% 98.41% -0.01%
==========================================
Files 43 43
Lines 1775 1767 -8
Branches 358 356 -2
==========================================
- Hits 1747 1739 -8
Misses 25 25
Partials 3 3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -24,12 +25,14 @@ def get_values(df: pd.DataFrame) -> SummaryStatistics: | |||
Returns | |||
------- | |||
SummaryStatistics | |||
Named tuple consisting of mean and standard deviations of x and y, | |||
Named tuple consisting of mean, median and standard deviations of x and y, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I much prefer Oxford commas, so let's change this to this:
Named tuple consisting of mean, median and standard deviations of x and y, | |
Named tuple consisting of mean, median, and standard deviations of x and y, |
Fixes #181
Describe your changes
Compute the median values for x and for y using the
pd.Series.median
method.Added median to the
get_values
docstring.Checklist