Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability for a user to delete one/multiple profiles #9807

Open
benjthayer opened this issue Mar 8, 2023 · 11 comments
Open

Adding the ability for a user to delete one/multiple profiles #9807

benjthayer opened this issue Mar 8, 2023 · 11 comments
Assignees
Milestone

Comments

@benjthayer
Copy link

benjthayer commented Mar 8, 2023

Currently there is no way for a user to delete one of their profiles.

After discussion with @John-44 we have created the following solution, enhancing the existing profile dropdown.

https://www.figma.com/file/17fc13UBFvInrLgNUKJJg5/Kuba%E2%8E%9CDesktop?node-id=26972-520493&t=LNBc5i9pzU8cJFDw-4

At the login screen, the profile selection dropdown contains a new item Manage profiles...

01

Clicking this launches the Manage profiles dialog where the user can see all of their available profiles. The user can click Done or X at any time to dismiss...

02

User chooses to delete profile simon.eth...

03

When the user clicks the delete icon, a confirmation dialog is shown, clarifying the destructive outcome...

ConfirmA

Once the user has confirmed, the confirmation dialog is dismissed and the Manage accounts list is updated with the deleted profile removed...

AdjustedList

When the user hits Done, the Manage accounts dialog is dismissed. Upon clicking the change profile dropdown again, they can see that the profile has also been deleted from that view...

06

The list has a max height and becomes scrollable as shown...

07

cc @John-44 @jrainville @iurimatias

@caybro
Copy link
Member

caybro commented Mar 9, 2023

@benjthayer just a question here: in order to delete an account, I hope the user is required to enter password ;) Otherwise a user could easily delete some one else's account

@jrainville
Copy link
Member

@benjthayer just a question here: in order to delete an account, I hope the user is required to enter password ;) Otherwise a user could easily delete some one else's account

I thought about that too, but since you're already on thee person's computer, you could just delete the DB in the files, so I'm not sure doing a password validation helps.

In a way, if I created an account, forget the password but I have the seed phrase, the only way for me to regen that account is to delete it first.

@caybro
Copy link
Member

caybro commented Mar 9, 2023

@benjthayer just a question here: in order to delete an account, I hope the user is required to enter password ;) Otherwise a user could easily delete some one else's account

I thought about that too, but since you're already on thee person's computer, you could just delete the DB in the files, so I'm not sure doing a password validation helps.

In a way, if I created an account, forget the password but I have the seed phrase, the only way for me to regen that account is to delete it first.

Yeah, you're right... nvm then 😊

@John-44
Copy link

John-44 commented Mar 9, 2023

@benjthayer @caybro minor terminology correction - it's not an account, it's a profile!!! ;-) Accounts are things that live inside the Wallet, profiles are, well.... "User accounts"... But it's confusing if we use the word "account" for two things, so better if we call these "Profiles" and the only thing we call "Accounts" is the accounts that live inside the wallet.

@benjthayer
Copy link
Author

benjthayer commented Mar 10, 2023

2 small adjustments made to the designs - updated the screenshots in the initial post above:

  1. Copy on Remove simon.eth profileconfirmation dialog tweaked following comments from the Documentation team.
  2. After the user confirms deletion, the Manage accounts dialog resizes in height, adjusting to the removal of the deleted profile.

@caybro @jrainville

@alexandraB99
Copy link
Contributor

@jrainville do we support this yet?

@iurimatias
Copy link
Member

note: this a task for backend

@iurimatias
Copy link
Member

moved to 2.29 due to lack of space in this milestone

@iurimatias iurimatias modified the milestones: 2.28.0 Beta, 2.29.0 Beta Feb 16, 2024
@iurimatias iurimatias modified the milestones: 2.29.0 Beta, 2.30.0 Beta Mar 4, 2024
@noeliaSD
Copy link
Contributor

@jrainville Is it there a backend task for supporting that? Or is it already implemented?

@jrainville
Copy link
Member

@jrainville Is it there a backend task for supporting that? Or is it already implemented?

As far as I know, mobile already has it implemented, so the status-go work exists. We just need to add the Nim backend, but that shouldn't be too hard as it's just function calls to call the API and a return/event when it's done

@jrainville
Copy link
Member

Backend task added here: #15350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

8 participants