Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatusChatInput] If a username that contains an ”_” is entered into the message input field, all text after it becomes italic #9698

Closed
imagiMary opened this issue Mar 1, 2023 · 7 comments

Comments

@imagiMary
Copy link

Version: 0.9
OS: Windows 10

If a username that contains an underscore character (”_”) is entered into the message input field, all text after it becomes italic. This is because underscore is a markdown character.

e.g. @Pepper_Talent renders the text succeeding the”_” in the message input field as italic, including the rest of the username, and this is incorrect.


Steps to reproduce:

  1. Navigate to any messaging or community channel screen that contains a message input field.

  2. Type a message in the message input field @ mentioning a user with a username that contains an underscore’ e.g. ‘@Mary_’ or ‘@Pepper_Talent’.

What currently incorrectly happens:

  1. In the message input field, the text following the username that contains an underscore will be rendered in italics.
    Note: The markdown character is not rendered in the message body area once the message is posted, this is correct.

Example screenshots:

32 Special charactors should not be rendered

 
32 Special charactors should not be rendered 2

 
What is supposed to happen:

  1. Markdown characters in usernames should be ignored. The text in the message input field should not be altered if a username that contains a markdown character is entered.

Other information
This is specific to underscores as the only other markdown character that is allowed in usernames (a hyphen) is correctly ignored when a username that contains a hyphen is entered.

@imagiMary imagiMary added the bug Something isn't working label Mar 1, 2023
@jrainville
Copy link
Member

Duplicate of #8475, but this new ticket contains more info, so I'll close the old one instead.

@alexandraB99
Copy link
Contributor

alexandraB99 commented Apr 3, 2023

@John-44 @imagiMary, these are already known issues, and more or less already reported (eg #7091). We have got design specs for how formatting should behave and will be implemented here. However this requires a bigger effort and testing and as it's going to most probably break things we decided to leave it for after MVP. That said, do you think it's such a high prio so that it's refactored/fixed in 0.12? (same applies for #9700)

@John-44
Copy link

John-44 commented Apr 3, 2023

@John-44 @imagiMary, these are already known issues, and more or less already reported (eg #7091). We have got design specs for how formatting should behave and will be implemented here. However this requires a bigger effort and testing and as it's going to most probably break things we decided to leave it for after MVP. That said, do you think it's such a high prio so that it's refactored/fixed in 0.12? (same applies for #9700)

We could bump it to 0.13 perhaps? I'll bump to 0.13 for now and then we can discuss on a call later this week

@John-44 John-44 modified the milestones: 0.12.0, 0.13 Apr 3, 2023
@alexandraB99
Copy link
Contributor

@John-44 shall we move #9700 also to 0.13 then?

@John-44
Copy link

John-44 commented Apr 5, 2023

@John-44 shall we move #9700 also to 0.13 then?

@alexandraB99 yes good point. I've just moved #9700 to 0.13

@caybro caybro self-assigned this Apr 6, 2023
@iurimatias iurimatias modified the milestones: 0.13, 0.14 May 8, 2023
@John-44 John-44 modified the milestones: 0.14, 0.15 Jun 3, 2023
@alexandraB99 alexandraB99 changed the title If a username that contains an ”_” is entered into the message input field, all text after it becomes italic [StatusChatInput] If a username that contains an ”_” is entered into the message input field, all text after it becomes italic Jul 27, 2023
@caybro caybro removed their assignment Sep 8, 2023
@caybro
Copy link
Member

caybro commented Sep 8, 2023

This is more of a refactor task with a minor impact; but quite a big one effort-wise. Pls reconsider moving this to "later"

@iurimatias
Copy link
Member

closing as this will be part of a wider rethink of this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

8 participants