Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Channel permissions] Creating/editing channel permissions will spawn multiple notifications #13369

Closed
alexjba opened this issue Jan 31, 2024 · 2 comments · Fixed by #13584
Closed

[Channel permissions] Creating/editing channel permissions will spawn multiple notifications #13369

alexjba opened this issue Jan 31, 2024 · 2 comments · Fixed by #13584
Assignees
@alexjba
Labels
E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP
Milestone
2.28.0 Beta

Comments

@alexjba
Copy link
Contributor

alexjba commented Jan 31, 2024

Description

Found in #12160

When creating/editing/deleting channel permissions multiple notifications will be spawned.

This example is from creating a channel with 1 permission and it shows 3 notifications:

Screen.Recording.2024-01-31.at.17.34.09.mov
@alexjba alexjba added ui-team E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP labels Jan 31, 2024
@alexjba alexjba mentioned this issue Jan 31, 2024
Merged
@iurimatias iurimatias added this to the 2.28.0 Beta milestone Feb 1, 2024
@alexjba alexjba added the blocked label Feb 2, 2024
@alexjba
Copy link
Contributor Author

alexjba commented Feb 2, 2024

Blocked by #12142. The channel permissions needs to land first.

@iurimatias
Copy link
Member

moving this to sprint 2

@iurimatias iurimatias assigned alexjba and unassigned alexandraB99 Feb 5, 2024
@alexjba alexjba removed the blocked label Feb 12, 2024
@alexjba alexjba mentioned this issue Feb 15, 2024
Merged
@alexjba alexjba linked a pull request Feb 15, 2024 that will close this issue
fix: Multiple permission update toasts are spawned #13584
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexjba alexjba

Labels
E:Desktop Comm Perms and Minting MVP Misc tasks about Community permissions that are not part of another Epic, due for the MVP
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.28.0 Beta
Development

Successfully merging a pull request may close this issue.

fix: Multiple permission update toasts are spawned status-im/status-desktop
3 participants
@iurimatias @alexandraB99 @alexjba