Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New activity details screens covering Buy and Sell Tx's via an exchange #10956

Closed
benjthayer opened this issue Jun 6, 2023 · 0 comments
Closed

Comments

@benjthayer
Copy link

benjthayer commented Jun 6, 2023

A new subset of activity details screens have been created which cover Receive and Send transactions which are a result of a Buy or Sell operation via an exchange.

Given we cannot detect (and therefore label a Buy or Sell Tx), whenever the Tx is detected to be coming from or going to an exchange address we hold in the list of known counterparties, we should show the following:


For a Buy Tx - show a Receive Tx from the exchange address
For a Sell Tx - show a Send Tx to the exchange address


Given these transactions happen outside of Status on the exchange itself, the ‘Signing method’ section of the activity detail will be omitted.

The send and receive Tx’s in these instances showcase the name of the exchange and feature the exchange icon both in the activity header and body of the Tx in the From/To sections as shown.

There are a total of 4 new activity details flows:

  1. Receive Tx as a result of a Buy operation via an exchange on Mainnet
  2. Receive Tx as a result of a Buy operation via an exchange on Arbitrum
  3. Send Tx as a result of a Sell operation via an exchange on Mainnet
  4. Send Tx as a result of a Sell operation via an exchange on Arbitrum

This new format of activity details (showing the exchange icon and name) should be used whenever we detect the Tx involves an address we hold in the list of known counterparties.

New activity overview list items for these scenarios are here:
https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=12457-303137&t=ApnsesITUY1dehw8-4

Screenshot 2023-06-06 at 17 13 24

Activity details designs here:
https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=15324-456837&t=ApnsesITUY1dehw8-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants