-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test vectors: use tarballs, allow multiple spec versions for progressive spec updates #514
Conversation
Don't merge this until I'm done reviewing it. |
scripts/setup_official_tests.sh
Outdated
download_lfs_files() { | ||
[[ -z "$1" ]] && { echo "usage: download_lfs_files() subdir_name"; exit 1; } | ||
# download/unpack Ethereum Foundation tests functions | ||
source "$SUBREPO_DIR/scripts/download_functions.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's for separating the download functions from their usage.
I need per-version flexibility for the CI compared to if someone does a manual clone and uses https://github.com/status-im/nim-eth2-official-tests/blob/master/download_test_vectors.sh
Azure CIs are showing:
|
The symlink is in the wrong order: |
8d695c2
to
df28f9e
Compare
This updates the test vectors.
Now we use the EF tarballs to ensure that no git clone ever uses the EF quota.
We can also have different versions of the test vectors at the same time to allow progressive updates to v0.9.0 as requested by @tersec.
The only usage left of LFS is for the SSZ test vectors that are still using v0.8.1 format. It is against our own LFS quota however.