Test vectors: use tarballs, allow multiple spec versions for progressive spec updates #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this until I'm done reviewing it. |
tersec
approved these changes
Oct 31, 2019
scripts/setup_official_tests.sh
Outdated
| download_lfs_files() { | ||
| [[ -z "$1" ]] && { echo "usage: download_lfs_files() subdir_name"; exit 1; } | ||
| # download/unpack Ethereum Foundation tests functions | ||
| source "$SUBREPO_DIR/scripts/download_functions.sh" |
There was a problem hiding this comment.
Why would you need this?
There was a problem hiding this comment.
That's for separating the download functions from their usage.
I need per-version flexibility for the CI compared to if someone does a manual clone and uses https://github.com/status-im/nim-eth2-official-tests/blob/master/download_test_vectors.sh
|
Azure CIs are showing: |
|
The symlink is in the wrong order: |
|
It was not. bash is playing tricks on me:
|
stefantalpalaru
force-pushed
the
update-test-vectors
branch
from
8d695c2
to
df28f9e
Compare
stefantalpalaru
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the test vectors.
Now we use the EF tarballs to ensure that no git clone ever uses the EF quota.
We can also have different versions of the test vectors at the same time to allow progressive updates to v0.9.0 as requested by @tersec.
The only usage left of LFS is for the SSZ test vectors that are still using v0.8.1 format. It is against our own LFS quota however.