Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tarballs missing vendor folder #6291

Open
eenagy opened this issue May 15, 2024 · 0 comments
Open

Release tarballs missing vendor folder #6291

eenagy opened this issue May 15, 2024 · 0 comments

Comments

@eenagy
Copy link

eenagy commented May 15, 2024

Bug Description
Release tarballs are missing the full source code. Although vendor folders are managed by git submodules, the release tarballs should provide a complete and reproducible source code that can be built independently. Currently, it is possible to build from the release tarball (if I tar it myself after git clone), but the absence of vendor folders creates issues.

This becomes a significant problem because git submodules are periodically updated. For instance, two weeks ago, one of the managed submodules was force-pushed, making it impossible to determine the exact source code the client was built from.

Steps to Reproduce

  1. Download the release tarball from Nimbus-eth2 v24.4.0.
  2. Extract the tarball.
  3. Notice that the vendor folder is missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant