Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Added closing tag to anchor for glyphicon. #304

Merged
merged 41 commits into from
Jun 21, 2021
Merged

Added closing tag to anchor for glyphicon. #304

merged 41 commits into from
Jun 21, 2021

Conversation

rmassoth
Copy link
Collaborator

Added a closing tag for the glyphicon link in sort_th_frag.html. The missing tag was causing the browser to render three links instead of one.

@staticdev
Copy link
Owner

staticdev commented Jun 18, 2021 •
edited
Loading

@rmassoth I saw we have a problem with safety here. Could you run a poetry update from your branch and commit the poetry.lock?

@staticdev staticdev linked an issue Jun 18, 2021 that may be closed by this pull request
Improper rendering of header links when using sort_th in django-sorting-bootstrap #305
Closed
@rmassoth
Copy link
Collaborator Author

I ran poetry update and ran nox locally but it's still failing safety for nox-poetry. It looks like nox-poetry is set to install exactly version 0.7.1 in the pyproject.toml file. Safety is complaining about versions lower than 0.8.2. Would it be safe to update the version or is there a reason to keep this specific version?

staticdev and others added 10 commits June 20, 2021 09:19
Removal nox-poetry
cd01af7
Fix nox versions
2fcb2be
Merge pull request staticdev#308 from staticdev/removal-nox-poetry
54d52c9 
Removal nox-poetry
@dependabot
Bump sphinx-rtd-theme from 0.5.1 to 0.5.2 in /docs
9aa2438 
Bumps [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/readthedocs/sphinx_rtd_theme/releases)
- [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst)
- [Commits](readthedocs/sphinx_rtd_theme@0.5.1...0.5.2)

---
updated-dependencies:
- dependency-name: sphinx-rtd-theme
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Fix release-drafter
6fba2a1
Merge pull request staticdev#313 from staticdev/fix-release-drafter
180c3fb 
Fix release-drafter
@dependabot
Bump flake8-rst-docstrings from 0.0.14 to 0.2.3
d1bd00c 
Bumps [flake8-rst-docstrings](https://github.com/peterjc/flake8-rst-docstrings) from 0.0.14 to 0.2.3.
- [Release notes](https://github.com/peterjc/flake8-rst-docstrings/releases)
- [Commits](peterjc/flake8-rst-docstrings@v0.0.14...v0.2.3)

---
updated-dependencies:
- dependency-name: flake8-rst-docstrings
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Add contributors
e38c570
Merge pull request staticdev#310 from staticdev/dependabot/pip/flake8…
19f1b27 
…-rst-docstrings-0.2.3

Bump flake8-rst-docstrings from 0.0.14 to 0.2.3
Fix contributos spaces
a54dafc
@staticdev
Copy link
Owner

@rmassoth I fixed the security problem, please rebase the PR and it will work.

Thiago and others added 14 commits June 20, 2021 11:06
Merge pull request staticdev#315 from staticdev/add-maintainer
c925fb9 
Add contributors
@dependabot
Bump sphinx from 3.5.4 to 4.0.2
c568c58 
Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 3.5.4 to 4.0.2.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/4.x/CHANGES)
- [Commits](sphinx-doc/sphinx@v3.5.4...v4.0.2)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump actions/cache from 2.1.3 to 2.1.6
c5f22a4 
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.3 to 2.1.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.3...v2.1.6)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request staticdev#295 from staticdev/dependabot/github_act…
f810941 
…ions/actions/cache-2.1.6

Bump actions/cache from 2.1.3 to 2.1.6
Merge pull request staticdev#316 from staticdev/dependabot/pip/sphinx…
81447eb 
…-4.0.2

Bump sphinx from 3.5.4 to 4.0.2
@dependabot
Bump codecov/codecov-action from 1.2.1 to 1.5.2
33298bd 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1.2.1 to 1.5.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.2.1...v1.5.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump pypa/gh-action-pypi-publish from 1.4.1 to 1.4.2
d1665a4 
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request staticdev#290 from staticdev/dependabot/pip/docs/s…
73f7dde 
…phinx-rtd-theme-0.5.2

Bump sphinx-rtd-theme from 0.5.1 to 0.5.2 in /docs
@dependabot
Bump pre-commit-hooks from 3.4.0 to 4.0.1
684f23a 
Bumps [pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) from 3.4.0 to 4.0.1.
- [Release notes](https://github.com/pre-commit/pre-commit-hooks/releases)
- [Changelog](https://github.com/pre-commit/pre-commit-hooks/blob/master/CHANGELOG.md)
- [Commits](pre-commit/pre-commit-hooks@v3.4.0...v4.0.1)

---
updated-dependencies:
- dependency-name: pre-commit-hooks
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request staticdev#311 from staticdev/dependabot/pip/pre-co…
456429c 
…mmit-hooks-4.0.1

Bump pre-commit-hooks from 3.4.0 to 4.0.1
Merge pull request staticdev#318 from staticdev/dependabot/github_act…
998ea46 
…ions/pypa/gh-action-pypi-publish-1.4.2

Bump pypa/gh-action-pypi-publish from 1.4.1 to 1.4.2
Merge pull request staticdev#317 from staticdev/dependabot/github_act…
f304085 
…ions/codecov/codecov-action-1.5.2

Bump codecov/codecov-action from 1.2.1 to 1.5.2
@dependabot
Bump sphinx-autobuild from 2020.9.1 to 2021.3.14
42cc59f 
Bumps [sphinx-autobuild](https://github.com/executablebooks/sphinx-autobuild) from 2020.9.1 to 2021.3.14.
- [Release notes](https://github.com/executablebooks/sphinx-autobuild/releases)
- [Changelog](https://github.com/executablebooks/sphinx-autobuild/blob/main/NEWS.rst)
- [Commits](https://github.com/executablebooks/sphinx-autobuild/commits)

---
updated-dependencies:
- dependency-name: sphinx-autobuild
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request staticdev#302 from staticdev/dependabot/pip/sphinx…
39b6acb 
…-autobuild-2021.3.14

Bump sphinx-autobuild from 2020.9.1 to 2021.3.14
dependabot bot and others added 16 commits June 20, 2021 13:33
@dependabot
Bump sphinx from 3.4.3 to 4.0.2 in /docs
fe633f8 
Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 3.4.3 to 4.0.2.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/4.x/CHANGES)
- [Commits](sphinx-doc/sphinx@v3.4.3...v4.0.2)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request staticdev#294 from staticdev/dependabot/pip/docs/s…
0ffc1b5 
…phinx-4.0.2

Bump sphinx from 3.4.3 to 4.0.2 in /docs
@dependabot
Bump mypy from 0.790 to 0.902
8edf434 
Bumps [mypy](https://github.com/python/mypy) from 0.790 to 0.902.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.790...v0.902)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request staticdev#319 from staticdev/dependabot/pip/mypy-0…
043b186 
….902

Bump mypy from 0.790 to 0.902
@dependabot
Bump black from 20.8b1 to 21.6b0
06f6f0a 
Bumps [black](https://github.com/psf/black) from 20.8b1 to 21.6b0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/commits)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Merge pull request staticdev#309 from staticdev/dependabot/pip/black-…
6aa18ef 
…21.6b0

Bump black from 20.8b1 to 21.6b0
@dependabot
Bump flake8-bugbear from 20.11.1 to 21.4.3
a3f6c95 
Bumps [flake8-bugbear](https://github.com/PyCQA/flake8-bugbear) from 20.11.1 to 21.4.3.
- [Release notes](https://github.com/PyCQA/flake8-bugbear/releases)
- [Commits](PyCQA/flake8-bugbear@20.11.1...21.4.3)

---
updated-dependencies:
- dependency-name: flake8-bugbear
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@staticdev
Merge pull request staticdev#300 from staticdev/dependabot/pip/flake8…
72dc264 
…-bugbear-21.4.3

Bump flake8-bugbear from 20.11.1 to 21.4.3
@dependabot
Bump actions/upload-artifact from 2.2.2 to 2.2.4
1d44f5c 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.2.2 to 2.2.4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v2.2.2...v2.2.4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@staticdev
Merge pull request staticdev#293 from staticdev/dependabot/github_act…
eadd074 
…ions/actions/upload-artifact-2.2.4

Bump actions/upload-artifact from 2.2.2 to 2.2.4
@dependabot
Bump actions/setup-python from 2.2.1 to 2.2.2
0a63f7c 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.2.1...v2.2.2)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@staticdev
Merge pull request staticdev#291 from staticdev/dependabot/github_act…
f010820 
…ions/actions/setup-python-2.2.2

Bump actions/setup-python from 2.2.1 to 2.2.2
@dependabot
Bump actions/download-artifact from 2.0.8 to 2.0.10
34b323c 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2.0.8 to 2.0.10.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v2.0.8...v2.0.10)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@staticdev
Merge pull request staticdev#287 from staticdev/dependabot/github_act…
6d6e251 
…ions/actions/download-artifact-2.0.10

Bump actions/download-artifact from 2.0.8 to 2.0.10
@baeadmin1
Added closing tag to anchor for glyphicon.
cec59a9
@baeadmin1
Merge branch 'sort_th_fix' of github.com:rmassoth/django-sorting-boot…
8fa7052 
…strap into sort_th_fix

Rebasing on upstream/main.
@rmassoth
Copy link
Collaborator Author

I rebased and merged my branch. Hopefully everything is good now. Thanks for your help!

@staticdev staticdev merged commit ff969a5 into staticdev:main Jun 21, 2021
@rmassoth rmassoth deleted the sort_th_fix branch June 21, 2021 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@staticdev staticdev staticdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper rendering of header links when using sort_th in django-sorting-bootstrap
3 participants
@rmassoth @staticdev @baeadmin1