-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: LS should not autocomplete private re-exports + scarb build
should not succeed when a private export is imported
#5859
Comments
deploy_syscall
is visible in a test moduledeploy_syscall
is visible in a test module
@misicnenad can I be assined this? |
@misicnenad I think you should import the following path instead: use starknet::syscalls::deploy_syscall; If this is the fix for you, then the problem is LS which autocompletes private re-exports. If you confirm, then I'll re-phrase the issue. |
@mkaput the issue I was describing is exactly this:
Maybe I should re-phrase the description. Another related issue is that running EDIT: I used a confusing description for the issue. Rephrased it to more accurately describe the problem. Note: I'm aware that |
deploy_syscall
is visible in a test modulescarb build
should not succeed when a private export is imported
yes indeed |
To build tests, you can run CC @misicnenad |
@maciektr that actually makes a lot of sense. Thanks a lot! |
Bug Report
Cairo version:
Current behavior:
Compiler complains that "Item
![image](https://private-user-images.githubusercontent.com/19427053/342243459-3ecc1dd0-8144-4bef-8a06-c9e61fcdd42a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3Mzk3ODMsIm5iZiI6MTcyNDczOTQ4MywicGF0aCI6Ii8xOTQyNzA1My8zNDIyNDM0NTktM2VjYzFkZDAtODE0NC00YmVmLThhMDYtYzllNjFmY2RkNDJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDA2MTgwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZjYmY1ZTE1MGU0ODE4ZjFmMmZiZjNhYWNmZDc4MWU4MTRjOWQxYjJkMjIxOTU0NmZlYTBhYTFjMmU1MTRmYTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.OLNAdAfxa93U_4pKal_Z4ZUWTqhlWXUDPvR44r1o59U)
core::starknet::deploy_syscall
is not visible in this context." in a test module, even though it one of the recommended imports by the LSP.Running
scarb build
in the terminal runs successfully despite this error.Running
scarb cairo-test
in the terminal fails with the "deploy_syscall is not visible in this context" error!Expected behavior:
Either:
deploy_syscall
in the autocomplete dialogscarb build
should fail when a private re-export is imported in a moduleSteps to reproduce:
The text was updated successfully, but these errors were encountered: