-
Notifications
You must be signed in to change notification settings - Fork 55
fix(Popup): close previous popup on enter key #985
fix(Popup): close previous popup on enter key #985
Conversation
Actually, we should use For now going to push changes to get it working. |
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
==========================================
+ Coverage 81.15% 81.26% +0.11%
==========================================
Files 673 671 -2
Lines 8654 8633 -21
Branches 1528 1524 -4
==========================================
- Hits 7023 7016 -7
+ Misses 1616 1602 -14
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing 👍 one comment
fyi @kuzhelov
I did extra method to reuse it as @Bugaa92 said Thank you guys for the reviews |
please, just update |
fixes #866
I found the line that makes this bug
I tried to make the test case for this, but still failed it
even though it seems working fine
Popup's updateOutsideClickSubscription method has setTimeout
the test case runs before setTimeout callback
I hope someone can help me to make the test case pass