This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(lib): export getNextElement, getPreviousElement and focusAsync
#981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
feat/export-more-focus-zone
branch
from
ac3a265
to
3f75d2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
=====================================
Coverage 81% 81%
=====================================
Files 665 665
Lines 8528 8528
Branches 1443 1443
=====================================
Hits 6908 6908
Misses 1606 1606
Partials 14 14
Continue to review full report at Codecov.
|
kuzhelov
reviewed
Feb 27, 2019
packages/react/src/index.ts
Outdated
| getPreviousElement, | ||
| focusAsync, | ||
| } from './lib/accessibility/FocusZone/focusUtilities' | ||
| export const focusZoneUtilities = { |
There was a problem hiding this comment.
just one thing - shouldn't it be a breaking change, given this code on the client's side:
import { FocusZoneUtilities, ... } from '@stardust-ui/react'There was a problem hiding this comment.
Oh, I see, great catch 👍
kuzhelov
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
getNextElement,getPreviousElementandfocusAsynctofocusZoneUtilities.ShorthandValue