-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=========================================
- Coverage 80.72% 80.7% -0.02%
=========================================
Files 659 659
Lines 8457 8459 +2
Branches 1429 1431 +2
=========================================
Hits 6827 6827
- Misses 1616 1618 +2
Partials 14 14
Continue to review full report at Codecov.
|
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, couple of comments
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
marginLeft: p.mine ? marginOffset : 0, | ||
marginRight: !p.mine ? marginOffset : 0, | ||
maxWidth: `calc(100% - ${marginOffset})`, | ||
minWidth: marginOffset, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would introduce the marginOffset as a variable, but it is used as minWidth as well, which will mean maybe we need variables... Just thinking out loud :) Maybe it's better if it stays as it is..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
No description provided.