-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 80.37% 80.38% +0.01%
==========================================
Files 656 657 +1
Lines 8393 8398 +5
Branches 1488 1424 -64
==========================================
+ Hits 6746 6751 +5
Misses 1632 1632
Partials 15 15
Continue to review full report at Codecov.
|
* @specification | ||
* Adds role='img'. | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be there an empty line? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a changelog entry 👍
@@ -28,6 +36,8 @@ export interface StatusProps extends UIComponentProps { | |||
|
|||
/** | |||
* A status graphically represents someone's or something's state. | |||
* @accessibility | |||
* Don't forget to put appropriate 'alt' attribute describing status. This is necessary for correct screen reader behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If alt
prop is so necessary, should be a component prop?
…m/stardust-ui/react into mituron/status-screen-reader-mode
We recognized if status is used in context then the status itself is not navigable with screen reader in the reader mode (like virtual cursor, scan mode, browse mode).
Se we need to put status as img with proper alt attribute. Then the reader navigate on the status element in reader mode.