This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): rename combobox to root in dropdownSearchInputStyles
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
I tried to enforce |
…thub.com/stardust-ui/react into fix/dropdown-search-inpur # Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 69
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
bmdalex
approved these changes
Feb 4, 2019
CHANGELOG.md
Outdated
| @@ -46,6 +49,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Exports `Menu`'s variables as `MenuItem` and `MenuDivider`'s variables in `Teams` theme @mnajdova ([#814](https://github.com/stardust-ui/react/pull/814)) | |||
| - Fix `Avatar` - Add white circle border in contrast theme @bcalvery ([#795](https://github.com/stardust-ui/react/pull/795)) | |||
| - Dix `MenuDivider` not shown on horizontal `Menu` @mnajdova ([#813](https://github.com/stardust-ui/react/pull/813)) | |||
| - Add `root` to `dropdownSearchInputStyles` @layershifter ([#816](https://github.com/stardust-ui/react/pull/816)) | |||
There was a problem hiding this comment.
already have the entry at line 24 :)
mnajdova
reviewed
Feb 4, 2019
| @@ -6,6 +6,8 @@ const dropdownSearchInputStyles: ComponentSlotStylesInput< | |||
| DropdownSearchInputProps, | |||
| DropdownVariables | |||
| > = { | |||
| root: {}, | |||
There was a problem hiding this comment.
What was the motivation for this? As I see in DropdownSearchInput.tsx we are not using styles.root, nor classes.root. I don't understand why we need this?
layershifter
changed the title
root to dropdownSearchInputStylescombobox to root in dropdownSearchInputStyles
…st-ui/react into fix/dropdown-search-inpur
silviuaavram
approved these changes
Feb 4, 2019
mnajdova
approved these changes
Feb 4, 2019
miroslavstastny
approved these changes
Feb 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #753.
BREAKING CHANGES
This PR will affect you only if you're using custom styling for
DropdownSearchInputcomponent.Before
After