-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Header): introduce 'color' variable #72
feat(Header): introduce 'color' variable #72
Conversation
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 85.89% 85.97% +0.07%
==========================================
Files 74 76 +2
Lines 1106 1112 +6
Branches 219 228 +9
==========================================
+ Hits 950 956 +6
Misses 149 149
Partials 7 7
Continue to review full report at Codecov.
|
@@ -34,16 +35,29 @@ class Header extends UIComponent<any, any> { | |||
|
|||
/** Align header content. */ | |||
textAlign: PropTypes.oneOf(['left', 'center', 'right', 'justified']), | |||
|
|||
/** Custom values for styling variables. */ | |||
variables: PropTypes.object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to add the variables prop? We don't have it added in any of the other components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! We should address this in the other components as well. Approving this PR.
…er-and-description
Header color
Introduce
color
property toHeader
andHeader.Description
TODO
API Proposal
Header - color (variable)
Defines color of
Header
.Header.Description - color (variable)
Defines color of header's description (Header.Description).