This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(lib): correctly handle arrays in felaSanitizeCssPlugin #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
kuzhelov
reviewed
Dec 6, 2018
src/lib/felaSanitizeCssPlugin.ts
Outdated
| @@ -39,7 +39,7 @@ export default (config?: { skip?: string[] }) => { | |||
| const cssPropertiesToSkip = [...((config && config.skip) || [])] | |||
|
|
|||
| const sanitizeCssStyleObject = styles => { | |||
| const processedStyles = {} | |||
| const processedStyles = Array.isArray(styles) ? [] : {} | |||
|
|
|||
| Object.keys(styles).forEach(cssPropertyName => { | |||
| const cssPropertyValue = styles[cssPropertyName] | |||
There was a problem hiding this comment.
nit: cssPropertyName -> cssPropertyNameOrIndex? Then intend would be easier to capture a week after :)
kuzhelov
reviewed
Dec 6, 2018
| @@ -62,4 +62,13 @@ describe('felaSanitizeCssPlugin', () => { | |||
|
|
|||
| assertCssPropertyValue(`url('../../lib')`, true) | |||
| }) | |||
|
|
|||
| describe('should pass arrays', () => { | |||
There was a problem hiding this comment.
A bit confused with the test name, as it doesn't provide some necessary insights to me. Specifically, here:should pass array - pass untouched? Process somehow? If process, then what is the logic that will be applied?
Would expect tests to cover the following logic:
if array is passed, then for each item of an array CSS styles sanitization should be applied
miroslavstastny
added
🚀 ready for review
and removed
needs author feedback
kuzhelov
approved these changes
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572
color: ['red', 'blue']is a valid style butfelaSanitizeCssPluginconverted this to following object:which is incorrect. Now the plugin handles arrays correctly.